Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: clarify that __dirname is module local #6018

Closed
wants to merge 1 commit into from
Closed

doc: clarify that __dirname is module local #6018

wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Apr 2, 2016

Pull Request check-list

  • Is the commit message formatted according to [CONTRIBUTING.md][0]?
  • Is a documentation update included (if this change modifies
    existing APIs, or introduces new ones)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Affected core subsystem(s)

doc

Description of change

Clarify the __dirname is module local.

Fixes: #5525

@jasnell jasnell added the doc Issues and PRs related to the documentations. label Apr 2, 2016
@jasnell
Copy link
Member Author

jasnell commented Apr 2, 2016

@nodejs/documentation

@thefourtheye
Copy link
Contributor

LGTM.

@r-52
Copy link
Contributor

r-52 commented Apr 2, 2016

LGTM

1 similar comment
@cjihrig
Copy link
Contributor

cjihrig commented Apr 2, 2016

LGTM

jasnell added a commit that referenced this pull request Apr 2, 2016
@jasnell
doc: clarify that __dirname is module local
c06824b 
Fixes: #5525
PR-URL: #6018
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@jasnell
Copy link
Member Author

jasnell commented Apr 2, 2016

Landed in c06824b

@jasnell jasnell closed this Apr 2, 2016
MylesBorins pushed a commit that referenced this pull request Apr 5, 2016
@jasnell
doc: clarify that __dirname is module local
0ae5d02 
Fixes: #5525
PR-URL: #6018
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This was referenced Apr 5, 2016
Closed
Merged
Closed
MylesBorins pushed a commit that referenced this pull request Apr 11, 2016
@jasnell
doc: clarify that __dirname is module local
9679e2d 
Fixes: #5525
PR-URL: #6018
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Apr 11, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jasnell @thefourtheye @r-52 @cjihrig @MylesBorins